Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update php-parser to 4.0 #75

Merged
merged 2 commits into from
Jun 26, 2018
Merged

update php-parser to 4.0 #75

merged 2 commits into from
Jun 26, 2018

Conversation

maglnet
Copy link
Owner

@maglnet maglnet commented Jun 26, 2018

this should fix #69

@Ocramius Ocramius added this to the 1.0.0 milestone Jun 26, 2018
@Ocramius Ocramius self-assigned this Jun 26, 2018
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius
Copy link
Collaborator

🚢

@Ocramius Ocramius merged commit f180153 into master Jun 26, 2018
@Ocramius Ocramius deleted the feature/php-parser-4.0 branch June 26, 2018 20:35
@rieschl
Copy link
Contributor

rieschl commented Jul 10, 2018

@Ocramius do you know when you can release a new tag with this changes? I have to use dev-master at the moment because it clashes with current phpstan and infection versions. Maybe 0.2.2 is easier before jumping to 1.0/stable? Thanks!

@Ocramius
Copy link
Collaborator

@rieschl a patch release is out of question, because dependency bumps can prevent upgrades downstream.

You'd either get a minor or the major release.

@maglnet I don't think there's anything blocking a 1.0.0 release (and we move to new major versions for further breakages, if needed). Would you agree if I tagged one?

@rieschl
Copy link
Contributor

rieschl commented Jul 10, 2018

ah sorry, my mistake. I'm okay with anything, as long as it's tagged ;)
Thanks!

@maglnet
Copy link
Owner Author

maglnet commented Jul 11, 2018

@Ocramius I'm fine with a 1.0.0 release.
I'm going to change your review marks of #77 tonight, and also tag a new minor or major then, depending if you release earlier :-)

@Ocramius
Copy link
Collaborator

@maglnet won't get to it, but I strongly endorse 1.0.0, since the tool is generally usable anyway 👍

@maglnet
Copy link
Owner Author

maglnet commented Jul 11, 2018

@Ocramius yes, I'll release THE version later this day 👍

@maglnet
Copy link
Owner Author

maglnet commented Jul 11, 2018

@rieschl tagged 1.0.0 a minute ago :-) feel free to use/test and give feedback

@rieschl
Copy link
Contributor

rieschl commented Jul 12, 2018

Thanks! I've been using dev-master for a while now and everything works as expected.
The only thing I noticed was that if a used package doesn't specify a php version in the require section, the update checker complains of missing PHP core libraries (SPL and stuff). If the package contains a composer.lock it doesn't work correctly for symbols of that package. But I haven't tested if it's a new issue or already existing in 0.2.1

SpacePossum added a commit to PHP-CS-Fixer/PHP-CS-Fixer that referenced this pull request Jul 12, 2018
…eradus)

This PR was merged into the 2.12 branch.

Discussion
----------

DX: Upgrade composer-require-checker to stable version

ref maglnet/ComposerRequireChecker#75 (comment)

Commits
-------

277ef4b DX: Upgrade composer-require-checker to stable version
MidnightDesign pushed a commit to MidnightDesign/ComposerRequireChecker that referenced this pull request Sep 17, 2020
Allow composer/semver ^2.0 || ^3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to PHP Parser 4.0
3 participants