Prevent using symfony/console with broken exit code handling #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Oct 2, 2018
composer.json
Outdated
| @@ -33,6 +33,9 @@ | |||
| "symfony/console": "^3.0 || ^4.0", | |||
| "webmozart/glob": "^4.1" | |||
| }, | |||
| "conflict": { | |||
| "symfony/console": "3.4.16|4.1.5" | |||
There was a problem hiding this comment.
Better simply bump ^3.4.17 | ^4.1.6 above instead - no need to support older versions, as they will obviously have older bugs anyway.
There was a problem hiding this comment.
Agreed, but they've not been released yet
There was a problem hiding this comment.
Then let's wait for a release and bump this afterwards
There was a problem hiding this comment.
Note that this affects everything that uses symfony/console, so doing a hunt for downstream consumers is like fighting windmills right now :-\
There was a problem hiding this comment.
Ok I've pushed your suggested change now
There was a problem hiding this comment.
I'll restart the build at the next symfony releases 👍
duncan3dc
force-pushed
the
avoid-exit-code-issue
branch
from
eb85b6f to
ad0b196
Compare
Ocramius
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in symfony/console 3.4.16 and 4.1.5 where the exit code is reported as success if it failed.
This obviously affects this tool in a major way rendering it useless in a CI environment, so this PR ensures this bug cannot be installed.