Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify which railties we want to require #60

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

Ilyeo
Copy link
Contributor

@Ilyeo Ilyeo commented Jun 27, 2024

Quick Info

We are being explicit about which railties we want to require in our
application. This is to be able to deploy our application successfully.

Also, we fixed an issue in the body of the posts when rendered and
addressed a deprecation warning about some assets not being
present in the asset pipeline. The latter occurs during builds.

We are being explicit about which railties we want to require in our
application. This for be able to deploy our application succesfully.
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 27, 2024 21:05 Inactive
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 27, 2024 22:52 Inactive
We have noticed how the body of the posts is not being rendered
correctly.

I have found that the `find_and_preserve` method is the one causing
the issue. If we move it, the body of the posts will be rendered
correctly.
@Ilyeo Ilyeo force-pushed the chore/specify-which-railties-we-want-to-require branch from 72038e7 to f8f4748 Compare June 28, 2024 00:23
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 00:23 Inactive
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 01:36 Inactive
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 01:48 Inactive
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 17:02 Inactive
@Ilyeo Ilyeo force-pushed the chore/specify-which-railties-we-want-to-require branch from 9c86ac7 to d23c935 Compare June 28, 2024 17:11
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 17:11 Inactive
The extension of the asset is required; otherwise, it won't be present
in the asset pipeline.
@Ilyeo Ilyeo force-pushed the chore/specify-which-railties-we-want-to-require branch from d23c935 to 2eb5902 Compare June 28, 2024 17:22
@magmaleads magmaleads temporarily deployed to today-i-lear-chore-spec-vks3v5 June 28, 2024 17:23 Inactive
@Ilyeo Ilyeo merged commit a6a4aa7 into main Jun 28, 2024
@Ilyeo Ilyeo deleted the chore/specify-which-railties-we-want-to-require branch June 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants