Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docusaurus): updated docusaurus #15604

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

conradogobato
Copy link

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

Security Considerations

@conradogobato conradogobato requested a review from a team as a code owner February 20, 2025 13:18
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: docs Documentation-related issue label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 37cee94.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Oops! Looks like you failed the Docs Lint & Check Generated Files In Sync.

Howto

♻️ Updated: ❌ The check is still failing the Docs Lint & Check Generated Files In Sync after the last commit.

@conradogobato conradogobato changed the title docs: updated docusaurus feat(docs): updated docusaurus Mar 17, 2025
Copy link
Contributor

github-actions bot commented Mar 17, 2025

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

@conradogobato conradogobato changed the title feat(docs): updated docusaurus fix(ci): updated docusaurus Mar 18, 2025
@conradogobato conradogobato changed the title fix(ci): updated docusaurus imp(ci): updated docusaurus Mar 18, 2025
@conradogobato conradogobato force-pushed the docs/docs-update-docusaurus branch from 71f0cb0 to 6eddb5c Compare March 18, 2025 16:08
@conradogobato conradogobato changed the title imp(ci): updated docusaurus docs(ci): updated docusaurus Mar 18, 2025
@conradogobato conradogobato changed the title docs(ci): updated docusaurus docs(chore): updated docusaurus Mar 18, 2025
@conradogobato conradogobato force-pushed the docs/docs-update-docusaurus branch from 6eddb5c to b65a30f Compare March 18, 2025 16:10
@conradogobato conradogobato changed the title docs(chore): updated docusaurus docs(docusaurus): updated docusaurus Mar 18, 2025
Changing the docusaurus version from costum to the standart open source release

Signed-off-by: conradogobato <conradogob07@gmail.com>
@conradogobato conradogobato force-pushed the docs/docs-update-docusaurus branch from 4be62dc to 03377f6 Compare March 18, 2025 16:13
@jordanvrtanoski jordanvrtanoski enabled auto-merge (squash) March 18, 2025 17:20
@jordanvrtanoski jordanvrtanoski requested review from lucasgonze and removed request for lucasgonze March 18, 2025 17:20
@lucasgonze
Copy link
Contributor

This is such a giant PR, I'm not sure how to review it. Let's discuss in Slack.

@jordanvrtanoski
Copy link
Contributor

The number of changes is large as the folder structure is changed and all the markdown files are moved in the new structure. In essence the only change that is done is to remove the customized docosaurus framework and replace it with the "vanila". By doing so, the makefile is removed as no longer needed, the Docerfile is updated, the docosaurus config is updated as well and finally the existing files are moved to new structure. No new framework are introduced.

@lucasgonze
Copy link
Contributor

Seems like this update in master didn't get picked up for some reason:
image

Copy link
Contributor

@lucasgonze lucasgonze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the workflow regression and either fix failing tests or comment on why failures should be accepted.

@jordanvrtanoski
Copy link
Contributor

Holding the merge of this PR until the transition to the new repository for the documentation. This change ill be considered during the migration.

@see7e
Copy link
Contributor

see7e commented Mar 21, 2025

Hi @conradogobato I'll review the files that you've changed at the magma-documentation#9. I've already made some changes regarding the version update of Docusaurus, for that I'll combine my changes with yours and give the credits at every file that you've added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation-related issue status: on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants