-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(docusaurus): updated docusaurus #15604
base: master
Are you sure you want to change the base?
docs(docusaurus): updated docusaurus #15604
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Oops! Looks like you failed the Howto
♻️ Updated: ❌ The check is still failing the Docs Lint & Check Generated Files In Sync after the last commit. |
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
71f0cb0
to
6eddb5c
Compare
6eddb5c
to
b65a30f
Compare
Changing the docusaurus version from costum to the standart open source release Signed-off-by: conradogobato <conradogob07@gmail.com>
4be62dc
to
03377f6
Compare
This is such a giant PR, I'm not sure how to review it. Let's discuss in Slack. |
The number of changes is large as the folder structure is changed and all the markdown files are moved in the new structure. In essence the only change that is done is to remove the customized docosaurus framework and replace it with the "vanila". By doing so, the makefile is removed as no longer needed, the Docerfile is updated, the docosaurus config is updated as well and finally the existing files are moved to new structure. No new framework are introduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the workflow regression and either fix failing tests or comment on why failures should be accepted.
Holding the merge of this PR until the transition to the new repository for the documentation. This change ill be considered during the migration. |
Hi @conradogobato I'll review the files that you've changed at the magma-documentation#9. I've already made some changes regarding the version update of Docusaurus, for that I'll combine my changes with yours and give the credits at every file that you've added. |
Summary
Test Plan
Additional Information
Security Considerations