-
Notifications
You must be signed in to change notification settings - Fork 102
Add "Other..." option for checkbox & list questions #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like the idea and it makes sense as an opt-in feature so that developters an enable it where needed. I will review the code later... I would argue that its better placed as the last element in the list rather than the first thought. Makes more sense to me. |
65e1f7e to
58ae6a5
Compare
|
A little bump to know if this has been reviewed yet 🙏 It would be a very useful feature |
staticdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the feature, I just made a small comment, it is not mandatory but I would prefer to not have the dots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some small comments.
And the tests fail, I don't have the time to check why at the moment though, maybe you can figure it out quicker than i can
staticdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit broke the tests. I pointed in comment why.
|
Cheers all, have made the requested changes. Sorry if the tests still don't pass, I would run them locally but it's a bit of a PITA due to M1 chip. Fingers crossed 🤞🏻 |
This PR adds a feature to checkbox and list questions which allows users to enter custom input. Just need to set
other=Truewhen creating the question.Screen.Recording.2022-10-03.at.15.34.32.mov