Refactor filtering on status for product feed export

magmodules · Mar 3, 2022 · 60536e8 · 60536e8
1 parent 5247a3f
commit 60536e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/Helper/Source.php b/Helper/Source.php
@@ -418,17 +418,8 @@ public function getProductFilters($type)
         if ($visibilityFilter) {
             $visibility = $this->getStoreValue(self::XPATH_VISIBILITY_OPTIONS);
             $filters['visibility'] = explode(',', $visibility);
-            $filters['visibility_parents'] = $filters['visibility'];
         } else {
-            $filters['visibility'] = [
-                Visibility::VISIBILITY_IN_CATALOG,
-                Visibility::VISIBILITY_IN_SEARCH,
-                Visibility::VISIBILITY_BOTH,
-            ];
-            $filters['visibility_parents'] = $filters['visibility'];
-            if (!empty($filters['relations'])) {
-                array_push($filters['visibility'], Visibility::VISIBILITY_NOT_VISIBLE);
-            }
+            $filters['visibility'] = [];
         }
 
         $filters['limit'] = preg_replace('/\D/', '', $this->getStoreValue(self::XPATH_LIMIT));

diff --git a/Model/Collection/Products.php b/Model/Collection/Products.php
@@ -404,8 +404,8 @@ public function getParents($parentRelations, $config)
                 }
             }
 
-            if (!empty($filters['visibility_parent'])) {
-                $collection->addAttributeToFilter('visibility', ['in' => $filters['visibility_parent']]);
+            if (!empty($filters['visibility'])) {
+                $collection->addAttributeToFilter('visibility', ['in' => $filters['visibility']]);
             }
 
             if (!empty($config['inventory']['attributes'])) {