doc: RuntimeAdapter #87

magne4000 · 2024-12-11T13:04:50Z

No description provided.

magne4000 · 2024-12-11T13:13:45Z

I published some doc around RuntimeAdapter that I merged for convenience https://universal-middleware.dev/reference/runtime-adapter

Do you think it's enough and understandable if we link this page from vike-node README?

brillout · 2024-12-11T13:29:04Z

LGTM, awesome. I'll leave a handful of comments about polishing potential.

docs/reference/runtime-adapter.md

brillout · 2024-12-11T13:45:31Z

Little thing in case it's easy to change: the inline code blocks have a blue text so I thought there were links, but there aren't links.

brillout · 2024-12-11T13:46:11Z

Review done. Really neat reference page.

magne4000 · 2024-12-11T13:58:56Z

Thanks for the review 👏

Little thing in case it's easy to change: the inline code blocks have a blue text so I thought there were links, but there aren't links.

Now that you mention it, it feels weird. It should be easy to change

brillout · 2024-12-11T14:03:48Z

Glad to help 💫

doc: RuntimeAdapter

56a6178

magne4000 merged commit d0a2f49 into main Dec 11, 2024
6 checks passed

magne4000 deleted the magne4000/doc-runtime-adapter branch December 11, 2024 13:08

brillout reviewed Dec 11, 2024

View reviewed changes