-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with JDK 17 #131
Comments
I suppose what @lvitaly means is: ArraysAsListSerializer is currently not compatible with Java 17, as a java.lang.reflect.InaccessibleObjectException is thrown when the class is created. This is no longer allowed:
Are there any plans to fix this? |
Sorry that I opened an issue without comment. @jvdvegt, I guess you are right, but I discovered that kryo added this serializer to the default list in v5.0.0 (see Kryo.java#L225). I discovered few more serializers that throw errors with JDK 17
Unfortunately, I didn't dig deep enough to find out the root cause, and here is an original thread with these issues in cqengine project (see npgall/cqengine#269). You can find there that almost all cqengine's tests except one (ReflectiveAttributeTest) are passing with JDK17 + kryo v5.2.0 without serializers mentioned above. |
The first one seems quite easy to fix, though it is slightly slower than the original version. See attached sourcecode. |
Stumbled across the issue with the The stacktrace is:
The error message is: |
Any updates on ArraysAsListSerializer compatibility with JDK 17? |
@tinder-johnbuhanan: Can't you simply use the built-in ArraysAsListSerializer from Kryo 5? If you are on Kryo 5, you don't need any custom serializers. If you are on Kryo 4, you can copy the |
1. Copy UnmodifiableCollectionsSerializer.java to our repository to fix compilable issue: `Unable to make field final java.util.Collection java.util.Collections$UnmodifiableCollection.c accessible: module java.base does not "opens java.util" to unnamed module @61322f9d ` Refer to magro/kryo-serializers#131 2. Upgrade jacoco to 0.8.8 3. For the arrow flight server, users should add `--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED` to JAVA_OPTS Refer to https://arrow.apache.org/docs/java/install.html 4. Fix some UT Signed-off-by: gengjun-git <gengjun@starrocks.com>
No description provided.
The text was updated successfully, but these errors were encountered: