-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make protocol buffers a separate dependency #59
Comments
Before considering a separate module for the protobuf serializer I'd try to set scope=provided or optional=true. Do you want to submit a pull request for this? |
Can do! Is there any reason why it wasn't optional from the start, like joda-time? |
I'm more comfortable with Gradle than with Maven, but I believe there is no need for changes in the code to accommodate |
That's what I asked myself :-) |
I am using a library that requires kryo-serializers as a dependency, called PaperDb. The library doesn't use any protobuf, but because of this dependency it adds almost ~7k methods because of it. In Android, method count is highly important because it affects app startup time, and some limitations around 65k methods before some VM hackery is required.
Sadly, the dependency cannot be transitively removed by maven/gradle either. I'd like to ask that a separate module is created containing just the protobuf code and dependency, if possible.
The text was updated successfully, but these errors were encountered: