Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protocol buffers a separate dependency #59

Closed
pakoito opened this issue Oct 4, 2016 · 4 comments
Closed

Make protocol buffers a separate dependency #59

pakoito opened this issue Oct 4, 2016 · 4 comments

Comments

@pakoito
Copy link
Contributor

pakoito commented Oct 4, 2016

I am using a library that requires kryo-serializers as a dependency, called PaperDb. The library doesn't use any protobuf, but because of this dependency it adds almost ~7k methods because of it. In Android, method count is highly important because it affects app startup time, and some limitations around 65k methods before some VM hackery is required.

Sadly, the dependency cannot be transitively removed by maven/gradle either. I'd like to ask that a separate module is created containing just the protobuf code and dependency, if possible.

@magro
Copy link
Owner

magro commented Oct 4, 2016

Before considering a separate module for the protobuf serializer I'd try to set scope=provided or optional=true. Do you want to submit a pull request for this?

@pakoito
Copy link
Contributor Author

pakoito commented Oct 4, 2016

Can do! Is there any reason why it wasn't optional from the start, like joda-time?

@pakoito
Copy link
Contributor Author

pakoito commented Oct 4, 2016

I'm more comfortable with Gradle than with Maven, but I believe there is no need for changes in the code to accommodate optional=true, right?

@magro
Copy link
Owner

magro commented Oct 4, 2016

That's what I asked myself :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants