Remove protocol buffers dependency #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 4, 2016 13:33
|
kryo-serializers has fixed the dependency magro/kryo-serializers#60 and released a new version https://github.com/magro/kryo-serializers/releases/tag/kryo-serializers-0.40 This PR is not relevant anymore. I'll do the update one now. |
|
Thanks! Also please make PR for |
|
Done! Merge the one you want! |
|
This should be the right one: #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in magro/kryo-serializers#59, kryo-serializer adds several dependencies that aren't used by PaperDb. One of them is protocol buffers, which is 6k lines heavy: http://www.methodscount.com/?lib=io.paperdb%3Apaperdb%3A1.5
This PR creates a local copy of the serializers tagged with the commit they were taken from, to be used until (if) kryo-serializers is updated to not include heavy dependencies. Joda-time is kept only as a test dependency.
This PR also updates the build scripts, plugins, and gradle to the latest version.