use export instead of the Javascript way #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I sent PR again.
I'm happy if you review this.
The error I met
In the case using TypeScript as a esbuild configuration language, an imported GasPlugin could not be resolved its type as Plugin.
This code made an error like below:
Why this error occured?
I thought that tsc could not notice that GasPlugin is exported since the syntax
esports.GasPlugin = GasPlugin
is not for TypeScript but Javascript.What does this PR change?
There are small changes in compiled files since I changed
exports.GasPlugin = GasPlugin
toexport = { GasPlugin }
inindex.ts
.before:
dist/index.d.ts
dist/index.js
after:
dist/index.d.ts
dist/index.js
These changes makes be able to resolved GasPlugin as a Plugin for esbuild in TypeScript.
The usage is no changes.