forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Issue #19205 Fixed: Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart. #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not displaying for mobile devices portrait view - Fixed issue with missing compare/wishlist buttons on related product listings on mobile view;
- Add swatch image config size
- Propagate payment error message
- Fixed css styles for page-actions div elements
… on import - Removing invalid image attributes from row
Get rid of unnecessary reviews queries on product listing: "select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)" This query was executed for each product on listing which didn't have a review summary(@see: Magento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtml)
… for product pages - Fixed template detection in 'ProductViewCounter' block
updated for 2.3.x
…or a configurable product - Use simple product to get price.
- Adding exception for orders with zero grandTotal
Update repo
…mage width/height ratio has ~2x difference - Changed the logic of calculating the coefficient of zoom
[2.3-develop] Bug Fixes
MAGETWO-91756 In Related product section add to wishlist and compare is not displaying for mobile devices portrait view MAGETWO-59789 Image Swatch size change not working [GitHub magento#6382] MAGETWO-91530 [2.3] Expose Authorize.net Response Codes in Checkout MAGETWO-56094 Header issue when resizing in Internet Explorer MAGETWO-95825 [Magento cloud] - Images revert to default placeholder on import MAGETWO-95805 User agent exception not setting the correct templates for product pages MAGETWO-95833 Shared gift registry does not show the special price for a configurable product MAGETWO-95821 Order fails on review step if gift card applied MAGETWO-95826 Zoomed part of images becomes distorted in case when image width/height ratio has ~2x difference MAGETWO-95818 [Magento Cloud] Default value for category URL path does not save MAGETWO-95816 Invoice PDF contain different address when use arabic symbols MAGETWO-95829 Product positions are incorrect after import MAGETWO-91513 Password reset email cannot be sent if the customer does not have customer attribute set that is changed to required after original account creation MAGETWO-96125 [2.3.x] Reward Points: "Invite a Friend" points not added with New Account Email Confirmation enabled
mahesh-rajawat
force-pushed
the
2.3-develop-PR-port-19260
branch
from
November 28, 2018 18:18
e0c1e9f
to
98ae6ae
Compare
mahesh-rajawat
pushed a commit
that referenced
this pull request
Dec 23, 2018
Update 2.3 develop branch
mahesh-rajawat
pushed a commit
that referenced
this pull request
Dec 23, 2018
Missing setTotalCount on $searchResults object in getList method
mahesh-rajawat
pushed a commit
that referenced
this pull request
Dec 23, 2018
Update 2.2 develop branch
mahesh-rajawat
pushed a commit
that referenced
this pull request
Jan 26, 2019
removes extra dot on "How to run Magento" in phpserve/README.md
nmalevanec
pushed a commit
that referenced
this pull request
Mar 4, 2019
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
mahesh-rajawat
pushed a commit
that referenced
this pull request
Apr 8, 2019
merge from magento/magento2
mahesh-rajawat
pushed a commit
that referenced
this pull request
Apr 8, 2019
Removed two times zlib.output_compression on
mahesh-rajawat
pushed a commit
that referenced
this pull request
Jun 7, 2019
…sh-1 Changed canonical_url to relative_url
mahesh-rajawat
pushed a commit
that referenced
this pull request
Jul 8, 2019
seo meta tag order best practices
mahesh-rajawat
pushed a commit
that referenced
this pull request
Oct 2, 2019
mahesh-rajawat
pushed a commit
that referenced
this pull request
Oct 2, 2019
mahesh-rajawat
pushed a commit
that referenced
this pull request
Oct 24, 2019
Issue #1: Static content deploy waits 3 sec in single-job mode after finish Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... } Issue magento#2: Static content deploy has 5 secs delay between checking if worker job finished processing. It leads up to 5 sec time waste before next job will start. Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec) On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#19260
All selections of a bundle option of type check box that were checked once are added to cart -- not all selected values displaying in cart. Now fixed in this PL
Description (*)
While adding Bundle Product having option type checkbox with 3 or more values, and other Bundle option having single value, to the Cart. It was only adding 2 product for first selection. Not its fixed.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)