Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Issue #19205 Fixed: Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart. #1

Closed
wants to merge 222 commits into from

Conversation

mahesh-rajawat
Copy link
Owner

Original Pull Request

magento#19260

All selections of a bundle option of type check box that were checked once are added to cart -- not all selected values displaying in cart. Now fixed in this PL

Description (*)

While adding Bundle Product having option type checkbox with 3 or more values, and other Bundle option having single value, to the Cart. It was only adding 2 product for first selection. Not its fixed.

Fixed Issues (if relevant)

  1. Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart magento/magento2#19205
  2. ...

Manual testing scenarios (*)

  1. Added a product having option type checkbox with 3 or more values, and other Bundle option having single value, to the Cart. Working
  2. Created a new Bundle Product and checked by Adding to the cart.
  3. Run the unit test command for Bundle Module, its also passed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Alexey Yakimovich and others added 30 commits September 26, 2018 18:13
… is not displaying for mobile devices portrait view

- Fixed issue with missing compare/wishlist buttons on related product listings on mobile view;
- Fixed css styles for page-actions div elements
… on import

- Removing invalid image attributes from row
Get rid of unnecessary reviews queries on product listing:
"select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)" 
This query was executed for each product on listing which didn't have a review summary(@see: Magento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtml)
… for product pages

- Fixed template detection in 'ProductViewCounter' block
…or a configurable product

- Use simple product to get price.
- Adding exception for orders with zero grandTotal
…mage width/height ratio has ~2x difference

- Changed the logic of calculating the coefficient of zoom
VeronikaYarats and others added 12 commits November 26, 2018 10:52
MAGETWO-91756 In Related product section add to wishlist and compare is not displaying for mobile devices portrait view
MAGETWO-59789 Image Swatch size change not working [GitHub magento#6382]
MAGETWO-91530 [2.3] Expose Authorize.net Response Codes in Checkout
MAGETWO-56094 Header issue when resizing in Internet Explorer
MAGETWO-95825 [Magento cloud] - Images revert to default placeholder on import
MAGETWO-95805 User agent exception not setting the correct templates for product pages
MAGETWO-95833 Shared gift registry does not show the special price for a configurable product
MAGETWO-95821 Order fails on review step if gift card applied
MAGETWO-95826 Zoomed part of images becomes distorted in case when image width/height ratio has ~2x difference
MAGETWO-95818 [Magento Cloud] Default value for category URL path does not save
MAGETWO-95816 Invoice PDF contain different address when use arabic symbols
MAGETWO-95829 Product positions are incorrect after import
MAGETWO-91513 Password reset email cannot be sent if the customer does not have customer attribute set that is changed to required after original account creation
MAGETWO-96125 [2.3.x] Reward Points: "Invite a Friend" points not added with New Account Email Confirmation enabled
@mahesh-rajawat mahesh-rajawat force-pushed the 2.3-develop-PR-port-19260 branch from e0c1e9f to 98ae6ae Compare November 28, 2018 18:18
mahesh-rajawat pushed a commit that referenced this pull request Dec 12, 2018
mahesh-rajawat pushed a commit that referenced this pull request Dec 12, 2018
mahesh-rajawat pushed a commit that referenced this pull request Dec 12, 2018
mahesh-rajawat pushed a commit that referenced this pull request Dec 23, 2018
mahesh-rajawat pushed a commit that referenced this pull request Dec 23, 2018
Missing setTotalCount on $searchResults object in getList method
mahesh-rajawat pushed a commit that referenced this pull request Dec 23, 2018
mahesh-rajawat pushed a commit that referenced this pull request Jan 26, 2019
removes extra dot on "How to run Magento" in phpserve/README.md
nmalevanec pushed a commit that referenced this pull request Mar 4, 2019
[Forwardport] 'Fixes-for-customer-login-page-input-field' :: On customer login page…
mahesh-rajawat pushed a commit that referenced this pull request Apr 8, 2019
merge from magento/magento2
mahesh-rajawat pushed a commit that referenced this pull request Apr 8, 2019
Removed two times zlib.output_compression on
mahesh-rajawat pushed a commit that referenced this pull request May 7, 2019
mahesh-rajawat pushed a commit that referenced this pull request Jun 7, 2019
…sh-1

Changed canonical_url to relative_url
mahesh-rajawat pushed a commit that referenced this pull request Jul 8, 2019
mahesh-rajawat pushed a commit that referenced this pull request Oct 2, 2019
mahesh-rajawat pushed a commit that referenced this pull request Oct 2, 2019
mahesh-rajawat pushed a commit that referenced this pull request Oct 24, 2019
Issue #1: Static content deploy waits 3 sec in single-job mode after finish
Fixed by moving this sleep() into if ($this->isCanBeParalleled()) { ... }

Issue magento#2: Static content deploy has 5 secs delay between checking if worker job finished processing.
It leads up to 5 sec time waste before next job will start.
Improved by decreasing time from 5 sec to 0.5 sec with saving log refresh rate (10*0.5 sec)

On 4 themes and 7 locales these fixes improve time of static content deploy by 10-15 secs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.