Make native dialogs optional. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If linking against big GTK+ library is undesired.
JoelLinn
force-pushed
the
feature-optional-native
branch
from
2e0feef to
44b43a2
Compare
|
Is there any issue with this PR? |
|
Joel, sorry for the delay. I haven't really had much time to look at this lately. I don't see any real issues with this. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native dialogs link against GTK+ which is about 8MB of shared lib dependencies.
If linking against big GTK+ library is undesired (In my case I would have to redistribute the GTK libs along the Python package on PyPi which itself is only about 1.5MB) this PR allows to disable Native dialogs.
I added the option
MAHI_GUI_NATIVE_DIAGSwhich definesMAHI_NATIVE_DIAGSin the processor if set toON.Let me now what you think. E.g. if you prefer a different option name I can rebase.