Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project: n8n #242

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix project: n8n #242

merged 2 commits into from
Jan 8, 2025

Conversation

MattTheCuber
Copy link
Contributor

@MattTheCuber MattTheCuber commented Jan 6, 2025

Closes #241

n8n's tags can't be scanned automatically due to the prefix (#237 would fix). For now I hardcoded the release information.

This prompted a couple questions:

  • Should n8n even be in this list? It was 0ver for 4 years (2019-2023), and it was only added to the list 3 days ago.
  • Do you consider the last 0ver release the newest 0ver release or the one preceding the first non-0ver release? Because lot's of times I see repos publishing many 0ver releases past their first non-0ver release (for fixes/patches and such).

@mahmoud
Copy link
Owner

mahmoud commented Jan 8, 2025

Haha, I do my best to be an inclusionist, so if someone makes a PR, I tend to merge it. I'd take it up w the author of #229 ;)

But that said, if the list is getting overly long, then yeah I'd say this would be on the earlier side of the chopping block.

As for your second point, that's a great nuance. I think either one is defensible, but I'm 80:20 on last release before the first non-0ver.

@mahmoud mahmoud merged commit c4fd365 into mahmoud:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI failing (due to n8n)
2 participants