Range based gets #2224
Merged
Range based gets #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
joshuef
force-pushed
the
RangeBasedGets
branch
from
90aa07d to
ca949c0
Compare
maqi
requested changes
Oct 11, 2024
joshuef
force-pushed
the
RangeBasedGets
branch
from
ca949c0 to
a8e4ea0
Compare
| timeout-minutes: 1 | ||
| # get the counts, then the specific line, and then the digit count only | ||
| # then check we have an expected level of restarts | ||
| # TODO: make this use an env var, or relate to testnet size |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
joshuef
force-pushed
the
RangeBasedGets
branch
from
416a2fc to
985a373
Compare
.github/workflows/merge.yml
Outdated
| timeout-minutes: 1 | ||
| # get the counts, then the specific line, and then the digit count only | ||
| # then check we have an expected level of restarts | ||
| # TODO: make this use an env var, or relate to testnet size |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
approved these changes
Oct 15, 2024
joshuef
force-pushed
the
RangeBasedGets
branch
3 times, most recently
from
0414408 to
2105881
Compare
… range replication
merge the results after we see split record. Use Quorum::Majority at least (instead of Quorum::One)
this indirectly affects how many close nodes returned and could stymie the GetRange effectiveness
ie, even if query times out if we have peers, we update seems like we timeout more due to high K_VALUE
previously we just dropped any attempt at comms there
joshuef
force-pushed
the
RangeBasedGets
branch
from
7daed93 to
0a500d0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joshuef
force-pushed
the
RangeBasedGets
branch
from
69cb217 to
972610c
Compare
maqi
added a commit
to maqi/autonomi
that referenced
this pull request
Oct 23, 2024
…sedGets"" This reverts commit 09c36c8.
maqi
added a commit
to maqi/autonomi
that referenced
this pull request
Oct 23, 2024
…sedGets"" This reverts commit 09c36c8.
maqi
added a commit
to maqi/autonomi
that referenced
this pull request
Oct 31, 2024
…/RangeBasedGets""" This reverts commit 49115fd.
jacderida
added a commit
that referenced
this pull request
Nov 2, 2024
Revert "Revert "Revert "Merge pull request #2224 from joshuef/RangeBasedGets"""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
.github/workflows/merge.ymlfile and thesn_clientmodule to improve functionality and error handling. The most important changes include updating job steps in the GitHub Actions workflow, adding new methods and parameters in thesn_clientAPI, and refining error handling in thesn_clientmodule.GitHub Actions Workflow Improvements:
.github/workflows/merge.yml.safe_test_logs_data_location_routing_tablein.github/workflows/merge.yml..github/workflows/merge.yml[1] [2].sn_clientAPI Enhancements:KBucketDistanceto the imports and introduced theget_rangemethod insn_client/src/api.rs[1] [2].get_signed_register_from_networkmethod to includeis_verifyingparameter and adjusted related methods to use this parameter for quorum and retry strategy [1] [2] [3].Error Handling Improvements:
FaucetDisbursementandNoCashNoteFoundinsn_client/src/error.rs[1] [2].CouldNotVerifyTransfererror variant and replaced its usage with more specific errors [1] [2].Miscellaneous:
sn_client/src/faucet.rs.sn_client/src/test_utils.rs.