Data refactor #2560
Merged
Data refactor #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weird anti rust pattern of storage dir plus a storage.rs existing. Fixed
* Add new Pointer type for network addressing * Add PointerAddress type and related network address handling * Implement signature verification for Pointer records * Add validation and storage handling for Pointer records in ant-node * Add log markers for Pointer operations * Make LinkedList outputs field optional by wrapping in Option<Vec> * Update LinkedList constructors and signature calculation to handle optional outputs * Fix transaction tests to use .into() for empty output vectors * Update ant-networking to handle split records for both Pointer and optional outputs * Maintain signature verification and count-based selection for split records * Add InvalidSignature error variant to handle Pointer validation failures This change introduces a new Pointer type for network addressing while also making LinkedList transactions more flexible by allowing them to be created without outputs. The networking layer has been updated to handle both changes, including proper split record handling, signature verification, and storage validation. All changes maintain backward compatibility with existing functionality.
…version numbers, and add tests
dirvine
force-pushed
the
data_refactor
branch
from
f4f51f0 to
f3013fe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jacderida
reviewed
Dec 29, 2024
dirvine
force-pushed
the
data_refactor
branch
from
8d54824 to
3c77da9
Compare
grumbach
approved these changes
Dec 30, 2024
Comment on lines
+32
to
+37
| pub enum PointerTarget { | ||
| ChunkAddress(ChunkAddress), | ||
| LinkedListAddress(LinkedListAddress), | ||
| PointerAddress(PointerAddress), | ||
| ScratchpadAddress(ScratchpadAddress), | ||
| } |
There was a problem hiding this comment.
I suppose we omitted registers here on purpose?
There was a problem hiding this comment.
Should this include DataMap, not just for files but arbitrary metadata?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Pointer Type and Refactor LinkedList Structure
Changes
Pointertype for network addressingLinkedListoutputs optionalDetails
New Pointer Type
PointerandPointerAddresstypes for network addressingant-nodeInvalidSignatureerror variant for validation failuresLinkedList Refactoring
outputsfield optional viaOption<Vec<(PublicKey, LinkedListContent)>>.into()for empty output vectorsNetworking Layer Updates
Testing
Impact
These changes improve the flexibility of the network addressing system while making
LinkedList transactions more versatile. The Pointer type provides a new way to handle
network addressing, while optional outputs in LinkedList allow for simpler transaction
structures when needed.
Breaking Changes
None. All changes maintain backward compatibility with existing functionality.