Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop syncing process if no connection to MailChimp's API available. #738

Closed
Santiagoebizmarts opened this issue Jun 27, 2018 · 0 comments
Closed

Stop syncing process if no connection to MailChimp's API available. #738

Santiagoebizmarts opened this issue Jun 27, 2018 · 0 comments
Assignees
@ebizmarts-keller
Labels
done enhancement
Milestone
1.1.13

Comments

@Santiagoebizmarts
Copy link
Contributor

Santiagoebizmarts commented Jun 27, 2018 •
edited
Loading

Preconditions

  1. Connection to MC API not available.
  2. Any version of extension and Magento.

Steps to reproduce

  1. Enable the extension and wait for the syncing process cron job to run.

Expected result

  1. Avoid doing unnecessary calls to the API after knowing the conection is not available.

Actual result

  1. Extension keeps trying to sync the data.

Same case for Magento 2 at mailchimp/mc-magento2#325
@ebizmarts-keller ebizmarts-keller self-assigned this Oct 16, 2018
@ebizmarts-keller ebizmarts-keller added this to the 1.1.13 milestone Oct 18, 2018
ebizmarts-keller added a commit that referenced this issue Oct 18, 2018
@ebizmarts-keller
#738 Modify error message
41fe634
ebizmarts-keller added a commit that referenced this issue Oct 18, 2018
@ebizmarts-keller
#738 Update message
8270c98
ebizmarts-keller added a commit that referenced this issue Oct 18, 2018
@ebizmarts-keller
Merge pull request #809 from mailchimp/issue738
4966e8c 
closes #738 Stop syncing process if can't connect to MC API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebizmarts-keller ebizmarts-keller

Labels
done enhancement
Projects
None yet
Milestone
1.1.13
Development

No branches or pull requests
2 participants
@Santiagoebizmarts @ebizmarts-keller