-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error table never getting cleaned up #1107
Milestone
Comments
gonzaloebiz
added a commit
that referenced
this issue
Mar 5, 2021
gonzaloebiz
added a commit
that referenced
this issue
Mar 5, 2021
gonzaloebiz
added a commit
that referenced
this issue
Mar 5, 2021
@gonzaloebiz When I apply the fix for this issue, will all existing mailchimp_errors entries be cleaned up automatically, or will I need to do manual work to clean these up? Currently we have 115 million entries in this table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue reporting guidelines
To maintain an effective bugfix workflow and make sure issues will be solved in a timely manner we kindly ask reporters to follow some simple guidelines.
Before creating an issue, please do the following:
If you are sure that the problem you are experiencing is caused by a bug, file a new issue in a Github issue tracker following the recommendations below.
Title
Title is a vital part of bug report for developer and trigger to quickly identify a unique issue. A well written title should contain a clear, brief explanation of the issue, making emphasis on the most important points.
Good example would be:
Unclear example:
Issue Description
The mailchimp_error table is never cleaned up resulting in 1.5G of physical space used on the disk for this table alone.
I'm also seeing error logs for batches that do not exist in the database anymore
Preconditions
Magento 2.4.1
mc-magento2 102.3.41
Steps to reproduce
Let some batches fail and log to the mailchimp_error table
Let these batches expire and get cleaned up by the mailchimp crons
Actual and Expected result
The error logs of these expired batches will still exist in the mailchimp_errors table and are never cleared.
I expect these to be deleted with the batches they are linked to, or to expire themselves after x amount of time
Additional information
As a possible solution we could add a Mysql relationship between the batches and the errors with
ON DELETE CASCADE
to automatically remove these logs when deleting batches.Or add the removal of the corresponding errors in the cleanup crons.
The text was updated successfully, but these errors were encountered: