Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync only works, if eCommerce is enabled #150

Closed
jhruehl opened this issue Dec 8, 2017 · 1 comment · Fixed by #165
Closed

Sync only works, if eCommerce is enabled #150

jhruehl opened this issue Dec 8, 2017 · 1 comment · Fixed by #165
Assignees
Milestone

Comments

@jhruehl
Copy link
Contributor

jhruehl commented Dec 8, 2017

I was wondering why the sync doesn't work, if the eCommerce option is disabled. So I had to again look into your code and only found one if-clause in www/app/code/Ebizmarts/MailChimp/Cron/Ecommerce.php
if ($this->_helper->getConfigValue(\Ebizmarts\MailChimp\Helper\Data::XML_PATH_ECOMMERCE_ACTIVE, $storeId))

So. Of cource subscribers aren't synced. Please implement another if-clause to check if Syncing is enabled and eCommerce is not and just copy the code from the existing one into that and remove all processes, which don't concern subscribers.

This would definitely solve the problem (checked it myself) and can be done in less than an hour.

@gonzaloebiz gonzaloebiz added the bug label Dec 8, 2017
@gonzaloebiz gonzaloebiz self-assigned this Dec 8, 2017
@gonzaloebiz gonzaloebiz added this to the 1.0.26 milestone Dec 8, 2017
@gonzaloebiz
Copy link
Collaborator

Thanks for your contribution @jhruehl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants