Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observer name "sales_order_save_after" is too generic. #1516

Closed
mpvdk opened this issue Aug 18, 2022 · 1 comment · Fixed by #1517, #1518, #1519, #1520 or #1521
Closed

Observer name "sales_order_save_after" is too generic. #1516

mpvdk opened this issue Aug 18, 2022 · 1 comment · Fixed by #1517, #1518, #1519, #1520 or #1521
Assignees
@gonzaloebiz
Labels
bug done Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.4
Milestone
10x.x.48

Comments

@mpvdk
Copy link

mpvdk commented Aug 18, 2022

There is an observer named "sales_order_save_after" in etc/adminhtml/events.xml. This name is too generic. Magento merges all observers in a keyed array, so if any have the same name, they override one another.

Suggested solution:

Rename observer to "mailchimp_sales_order_save_after". Which adheres to the logic all your other observers are named.
@gonzaloebiz gonzaloebiz self-assigned this Aug 18, 2022
@gonzaloebiz gonzaloebiz added this to the 10x.x.48 milestone Aug 18, 2022
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin observers closes #1516 for magento 2.4
97b85d3
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin observers closes #1516 for magento 2.3.6-p1
955ff2d
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin observers closes #1516 for magento 2.4
26a5344
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin observers closes #1516 for magento 2.3
2c1fc5b
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin events closes #1516 for magento 2.2
02f4deb
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
rename all admin observers closes #1516 for magento 2.1
1226d18
This was linked to pull requests Aug 18, 2022
rename all admin observers closes #1516 for magento 2.1 #1517
Merged
rename all admin events closes #1516 for magento 2.2 #1518
Merged
rename all admin observers closes #1516 for magento 2.3.6-p1 #1519
Merged
rename all admin observers closes #1516 for magento 2.3 #1520
Merged
Issue1516 2.4 #1521
Merged
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
Merge pull request #1517 from mailchimp/Issue1516-2.1
ea63fd5 
rename all admin observers closes #1516 for magento 2.1
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
Merge pull request #1518 from mailchimp/Issue1516-2.2
97df155 
rename all admin events closes #1516 for magento 2.2
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
Merge pull request #1519 from mailchimp/Issue1516-2.3.6-p1
db97772 
rename all admin observers closes #1516 for magento 2.3.6-p1
gonzaloebiz added a commit that referenced this issue Aug 18, 2022
@gonzaloebiz
Merge pull request #1520 from mailchimp/Issue1516-2.3
6610cde 
rename all admin observers closes #1516 for magento 2.3
@gonzaloebiz
Copy link
Collaborator

Thanks @mpvdk for pointing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonzaloebiz gonzaloebiz

Labels
bug done Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.4
Projects
None yet
Milestone
10x.x.48
2 participants
@gonzaloebiz @mpvdk