Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 103.4.53 caused UPDATE on over 60% of the existing (old) orders #1772

Closed
lbajsarowicz opened this issue Aug 17, 2023 · 1 comment · Fixed by #1773, #1774, #1775, #1776 or #1777
Closed

Comments

@lbajsarowicz
Copy link

lbajsarowicz commented Aug 17, 2023

Issue Description

My Client has 130.000 orders in their store. As Mailchimp official extension is full of bugs, I decided to upgrade the extension from 103.4.51 to 103.4.53, which is considered a patch version, thus should not introduce any backwards incompatible changes.

The Data Patch introduced in the scope of release

https://github.com/mailchimp/mc-magento2/blob/develop-2.4/Setup/Patch/Data/Migrate452.php

Caused update of 80000 out of 130000 orders in the database. As a result, the ERP synchronization queue is already stuck for 2 days.

Preconditions

  1. Regular 103.4.51 to 103.4.53 upgrade.

Steps to reproduce

A/A

Actual and Expected result


Additional information

When you introduce changes that affect existing data in the database:

  1. Change the minor (second), not patch (third) version number,
  2. Make it optional (i.e. as CLI command that Developer needs to call through CLI),
  3. Just don't.
@lbajsarowicz lbajsarowicz changed the title Upgrade to 103.4.53 caused UPDATE on 80.000 orders Upgrade to 103.4.53 caused UPDATE on over 60% of the existing (old) orders Aug 17, 2023
@dverkade
Copy link

This caused issues for several of our customers when deploying to production.

gonzaloebiz added a commit that referenced this issue Aug 21, 2023
gonzaloebiz added a commit that referenced this issue Aug 21, 2023
gonzaloebiz added a commit that referenced this issue Aug 21, 2023
gonzaloebiz added a commit that referenced this issue Aug 21, 2023
gonzaloebiz added a commit that referenced this issue Aug 21, 2023
@gonzaloebiz gonzaloebiz self-assigned this Aug 21, 2023
@gonzaloebiz gonzaloebiz added this to the 10x.x.54 milestone Aug 21, 2023
gonzaloebiz added a commit that referenced this issue Aug 22, 2023
gonzaloebiz added a commit that referenced this issue Aug 22, 2023
gonzaloebiz added a commit that referenced this issue Aug 22, 2023
gonzaloebiz added a commit that referenced this issue Aug 22, 2023
gonzaloebiz added a commit that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment