Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abs fail when discount amount is null #1921

Closed
gonzaloebiz opened this issue Mar 18, 2024 · 0 comments · Fixed by #1922, #1923, #1924, #1925 or #1926
Closed

Abs fail when discount amount is null #1921

gonzaloebiz opened this issue Mar 18, 2024 · 0 comments · Fixed by #1922, #1923, #1924, #1925 or #1926
Assignees
@gonzaloebiz
Labels
bug Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.3.6-p1 Magento 2.4
Milestone
10x.x.60

Comments

@gonzaloebiz
Copy link
Collaborator

Issue Description

When sync orders, sometimes the discount amount is null and not zero, this cause to fail the abs function
@gonzaloebiz gonzaloebiz added this to the 10x.x.60 milestone Mar 18, 2024
@gonzaloebiz gonzaloebiz self-assigned this Mar 18, 2024
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
closes #1921 for 2.4
d0c860c
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
closes #1921 for magento 2.3.6-p1
683f5b2
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
closes #1921 for magento 2.3
7868ef4
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
closes #1921 for magento 2.2
daf5ac7
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
closes #1921 for magento 2.1
b946c43
This was linked to pull requests Mar 18, 2024
closes #1921 for 2.4 #1922
Merged
closes #1921 for magento 2.3.6-p1 #1923
Merged
closes #1921 for magento 2.3 #1924
Merged
closes #1921 for magento 2.2 #1925
Merged
closes #1921 for magento 2.1 #1926
Merged
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
Merge pull request #1922 from mailchimp/Issue1921-2.4
d7ed0a4 
closes #1921 for 2.4
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
Merge pull request #1923 from mailchimp/Issue1921-2.3.6-p1
1bbb535 
closes #1921 for magento 2.3.6-p1
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
Merge pull request #1924 from mailchimp/Issue1921-2.3
af4dc00 
closes #1921 for magento 2.3
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
Merge pull request #1925 from mailchimp/Issue1921-2.2
1e95b23 
 closes #1921 for magento 2.2
gonzaloebiz added a commit that referenced this issue Mar 18, 2024
@gonzaloebiz
Merge pull request #1926 from mailchimp/Issue1921-2.1
c14928e 
closes #1921 for magento 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gonzaloebiz gonzaloebiz

Labels
bug Magento 2.1 Magento 2.2 Magento 2.3 Magento 2.3.6-p1 Magento 2.4
Projects
None yet
Milestone
10x.x.60
1 participant
@gonzaloebiz