Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some exceptions are not added into logs, making it hard to find the error message. #700

Closed
Santiagoebizmarts opened this issue May 9, 2019 · 0 comments

Comments

@Santiagoebizmarts
Copy link
Contributor

Santiagoebizmarts commented May 9, 2019

Issue Description

Preconditions

  1. Mailchimp for Magento 2 10x.x.34
  2. Any Magento version

Steps to reproduce

One example is when an order contains a product that was deleted from Magento. The error message: "The requested product doesn't exist" is only saved in the database table mailchimp_sync_ecommerce making it hard for a normal user to read it.

Actual and Expected result

Add the error message in the logs or in the error table.

Additional information

Places found that are currently not logging errors:

} catch (\Exception $e) {

} catch (\Exception $e) {

} catch (\Exception $e) {

} catch (\Exception $e) {

} catch (\Exception $e) {

} catch (\Exception $e) {

gonzaloebiz added a commit that referenced this issue May 27, 2019
gonzaloebiz added a commit that referenced this issue May 27, 2019
gonzaloebiz added a commit that referenced this issue May 27, 2019
gonzaloebiz added a commit that referenced this issue May 27, 2019
gonzaloebiz added a commit that referenced this issue May 27, 2019
gonzaloebiz added a commit that referenced this issue May 27, 2019
@gonzaloebiz gonzaloebiz self-assigned this May 27, 2019
@gonzaloebiz gonzaloebiz added this to the 1.x.35 milestone May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants