Adding extra logging on import parts of the Cronjob #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding extra logging on import parts of the Cronjob. There is a bit lack of visibility around execution of the sync process. Would be awesome to see where the sync spends more time and helps to diagnose, if the sync stuck somewhere due to some reason. E.g. Reasons: - Payload was not able to generate due to M2 Core issue and failed with warning or fatal error - You can see how much time been spent on specific part e.g. products, orders and etc. It helped me to diagnose that cart generation was taking about 20 minutes to generate due to some slow SQL query
Create temporary directory, if that does not exist to avoid error "Failed to open stream: No such file or directory"
Create temporary directory, if that does not exist
gonzaloebiz
requested changes
Sep 12, 2018
|
Hi @gonzaloebiz Thanks for the review. Issue has been created: #393 PR has been adjusted Regards, |
gonzaloebiz
approved these changes
Sep 13, 2018
|
thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra logging on import parts of the Cronjob.
There is a bit lack of visibility around execution of the sync process.
Would be awesome to see where the sync spends more time and helps to diagnose, if the sync stuck somewhere due to some reason.
E.g. Reasons: