Listen on IPv4 and IPv6 by default #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APEX-SAID-SHAMKHALI
approved these changes
Aug 2, 2024
|
Thanks @am97! This will be in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #484
Maildev currently listens on IPv4 only, which causes the healthcheck to fail with some Docker versions or custom daemon settings. Most dockerized apps that I've seen listen on both IPv4 and IPv6.
This should be documented as a breaking change to avoid unwanted exposure of Maildev in case someone has a particular config (for example a Docker daemon configured to use a public IPv6 block)