De 1301 mailgun sdk the template search filters do not match the documentation #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Api/DomainV4.php
# Conflicts: # src/Api/DomainV4.php
# Conflicts: # src/Api/DomainV4.php
oleksandr-mykhailenko
deleted the
DE-1301-mailgun-sdk-the-template-search-filters-do-not-match-the-documentation
branch
CadenP
reviewed
Aug 12, 2024
Comment on lines
-159
to
162
| // We should assert that "vars"'s $value is a string. | ||
| break; | ||
| // We should assert that "vars"'s $value is a string. | ||
| // no break | ||
| case 'name': |
There was a problem hiding this comment.
Just checking: should this break have been added? There's a comment two lines below that says "no break", and the comment above that seems to explain why. json_encode could return false, so perhaps that's what was being avoided here.
I haven't read through any of this code, so I don't know what it does, and I'm not using this version, so I don't know whether it breaks or improves anything. I just happened across this and thought I'd point it out and ask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.