Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De 1301 mailgun sdk the template search filters do not match the documentation #914

Conversation

oleksandr-mykhailenko
Copy link
Collaborator

No description provided.

@oleksandr-mykhailenko oleksandr-mykhailenko merged commit 9b6391d into master Jul 30, 2024
17 checks passed
@oleksandr-mykhailenko oleksandr-mykhailenko deleted the DE-1301-mailgun-sdk-the-template-search-filters-do-not-match-the-documentation branch July 30, 2024 15:03
Comment on lines -159 to 162
// We should assert that "vars"'s $value is a string.
break;
// We should assert that "vars"'s $value is a string.
// no break
case 'name':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: should this break have been added? There's a comment two lines below that says "no break", and the comment above that seems to explain why. json_encode could return false, so perhaps that's what was being avoided here.

I haven't read through any of this code, so I don't know what it does, and I'm not using this version, so I don't know whether it breaks or improves anything. I just happened across this and thought I'd point it out and ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants