-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De 1301 mailgun sdk the template search filters do not match the documentation #914
De 1301 mailgun sdk the template search filters do not match the documentation #914
Conversation
# Conflicts: # src/Api/DomainV4.php
# Conflicts: # src/Api/DomainV4.php
# Conflicts: # src/Api/DomainV4.php
// We should assert that "vars"'s $value is a string. | ||
break; | ||
// We should assert that "vars"'s $value is a string. | ||
// no break | ||
case 'name': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: should this break
have been added? There's a comment two lines below that says "no break", and the comment above that seems to explain why. json_encode
could return false
, so perhaps that's what was being avoided here.
I haven't read through any of this code, so I don't know what it does, and I'm not using this version, so I don't know whether it breaks or improves anything. I just happened across this and thought I'd point it out and ask.
No description provided.