Cleaning up Dockerfile, adding one for Mongo #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had problems with the provided Dockerfile, so I reworked it, tested it out, and switched it to using a "builder pattern" instead of trying to clean up after doing the build. The "Dockerfile" now builds in the "golang:alpine" Docker image, and builds an image using the base "alpine:latest" image for a smaller resulting image. I also included a "Dockerfile-mongodb" that similarly uses the "builder pattern" to build based on a MongoDB base Docker image, and then sets itself up to run MailHog with MongoDB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had problems with the provided Dockerfile, so I reworked it, tested it
out, and switched it to using a "builder pattern" instead of trying to
clean up after doing the build.
The "Dockerfile" now builds in the "golang:alpine" Docker image, and
builds an image using the base "alpine:latest" image for a smaller
resulting image.
I also included a "Dockerfile-mongodb" that similarly uses the "builder
pattern" to build based on a MongoDB base Docker image, and then sets
itself up to run MailHog with MongoDB.