feat: add support for V4 delete contact endpoint #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtopc
reviewed
Nov 27, 2024
| @@ -209,6 +209,20 @@ func (c *Client) Delete(mr *Request) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| // Special case of Delete for API v4 (e.g. delete contacts in case of GDPR requests) | |||
| func (c *Client) DeleteV4(mr *Request) (err error) { | |||
There was a problem hiding this comment.
Based on https://dev.mailjet.com/email/guides/contact-management/#overview it looks like the v3 delete is not a thing anymore. So better just to update the origin Delete func.
vtopc
reviewed
Nov 27, 2024
Comment on lines
+174
to
+175
| func buildURLV4(baseURL string, info *Request) string { | ||
| tokens := []string{baseURL, info.Resource} |
There was a problem hiding this comment.
Doesn't look DRY to me.
Could you refactor old buildURL and new buildURLV4 into:
func buildURL(baseURL string, info *Request) string {
buildURLPath([]string{baseURL, apiPath, info})
}
func buildURLV4(baseURL string, info *Request) string {
buildURLPath([]string{baseURL, info})
}
or something like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
There's a case where if folks try to use
mailjet-apiv3-goclient to delete contacts, e.g. due to GDPR requests, where we get a 401 error.This is due to the fact that we are sending the DELETE request to /v3 api.
If we use the client's
SetURLorSetBaseURLto override the base URL and send it to /v4 instead, the/RESTpath is still added. This PR adds a workaround to support sending requests like Delete contact to /v4 in a way that won't add the extra/RESTpath.Note to the maintainers of mailjet client: this was just a quick "hacky" way/workaround, but I would be happy to help make this PR into a more clean/mergeable state if provided with some guidance.