Skip to content

Conversation

@Benjamin-fr
Copy link

@Benjamin-fr Benjamin-fr commented Jan 8, 2026

Motivation

Symfony 8.0 unsupported

Changes

Update composer.json

How to test

  • unit test with php8.4

Summary by CodeRabbit

  • Chores
    • Updated package constraints to add compatibility with Symfony 8 for runtime and development tooling.
  • Tests
    • Expanded CI matrix to include Symfony 8 on PHP 8.4, increasing test coverage for the new compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

Expanded Symfony compatibility: added ^8.0 to symfony/mime (require) and to symfony/http-client and symfony/mailer (require-dev); CI matrix updated to include Symfony 8 on PHP 8.4 in PHPUnit workflows.

Changes

Cohort / File(s) Summary
Dependency constraints
composer.json
Relaxed version constraints to allow Symfony 8: symfony/mime (require) and symfony/http-client, symfony/mailer (require-dev) changed from `^6.0
CI matrix update
.github/workflows/ci-phpunit.yml
Added Symfony 8 / PHP 8.4 entries to PHPUnit workflow matrices.

Sequence Diagram(s)

(Section intentionally omitted — changes are limited to dependency constraints and CI matrix; no new multi-component control flow introduced.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Improve CI tests #58 — Updates CI workflow matrices and adds support for newer framework versions (similar CI matrix edits).

Suggested reviewers

  • leonid-shevtsov
  • i7an
  • mklocek

Poem

🐰 I nibbled versions in the light,

Symfony Eight hopped into sight,
Mime and Mailer, Client too,
CI nodded, added a view,
A carrot-toast to compatibility!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is largely incomplete. While it mentions motivation and updates to composer.json, it lacks detailed explanation of changes and testing instructions are minimal. Expand the description with specific details about which Symfony packages were updated, provide clear testing instructions with step-by-step guidance, and consider adding before/after comparison or impacts.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Symfony 8 compatibility' accurately summarizes the main change—adding Symfony 8 support to the project by updating dependencies and CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7c00812 and 37d272b.

📒 Files selected for processing (1)
  • .github/workflows/ci-phpunit.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci-phpunit.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
composer.json (1)

8-8: PHP version constraint should be updated to support Symfony 8.0.

Symfony 8.0 requires PHP 8.4 or higher, but this project specifies "php": "^8.0". While Composer will technically resolve this by selecting Symfony 6 or 7 for PHP 8.0-8.3, adding ^8.0 to the version constraints creates ambiguity about the intended PHP support level.

Update the PHP requirement to clarify intent:

  • To ensure Symfony 8.0 support: Update to "php": "^8.4"
  • To maintain PHP 8.0+ compatibility (letting Composer select versions based on PHP): Update to "php": "^8.2" (allows 8.2-8.3 users to stay on Symfony 6/7, 8.4+ users to use 8.0)

Without this change, users on PHP 8.0-8.3 will not receive Symfony 8.0 despite the constraint appearing to allow it.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac49b00 and 39aeeff.

📒 Files selected for processing (1)
  • composer.json

@Benjamin-fr
Copy link
Author

Done

@Benjamin-fr Benjamin-fr closed this Jan 8, 2026
@Benjamin-fr Benjamin-fr reopened this Jan 8, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/ci-phpunit.yml:
- Around line 107-108: The laravel job incorrectly contains a Symfony entry;
remove the "symfony: '8'" and associated "php-version: '8.4'" entries from the
laravel matrix and add that Symfony 8 / PHP 8.4 combination to the symfony job's
matrix instead, then ensure the symfony job uses matrix.symfony and
matrix.php-version and includes the Symfony-specific setup (symfony/flex) like
the other symfony matrix entries; also verify any job-name templates referencing
matrix.laravel are only used in the laravel job or updated to reference the
correct matrix key so they won't be empty for Symfony entries.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39aeeff and 7c00812.

📒 Files selected for processing (1)
  • .github/workflows/ci-phpunit.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant