-
Notifications
You must be signed in to change notification settings - Fork 13
Symfony 8 compatibility #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughExpanded Symfony compatibility: added Changes
Sequence Diagram(s)(Section intentionally omitted — changes are limited to dependency constraints and CI matrix; no new multi-component control flow introduced.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
composer.json (1)
8-8: PHP version constraint should be updated to support Symfony 8.0.Symfony 8.0 requires PHP 8.4 or higher, but this project specifies
"php": "^8.0". While Composer will technically resolve this by selecting Symfony 6 or 7 for PHP 8.0-8.3, adding^8.0to the version constraints creates ambiguity about the intended PHP support level.Update the PHP requirement to clarify intent:
- To ensure Symfony 8.0 support: Update to
"php": "^8.4"- To maintain PHP 8.0+ compatibility (letting Composer select versions based on PHP): Update to
"php": "^8.2"(allows 8.2-8.3 users to stay on Symfony 6/7, 8.4+ users to use 8.0)Without this change, users on PHP 8.0-8.3 will not receive Symfony 8.0 despite the constraint appearing to allow it.
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/ci-phpunit.yml:
- Around line 107-108: The laravel job incorrectly contains a Symfony entry;
remove the "symfony: '8'" and associated "php-version: '8.4'" entries from the
laravel matrix and add that Symfony 8 / PHP 8.4 combination to the symfony job's
matrix instead, then ensure the symfony job uses matrix.symfony and
matrix.php-version and includes the Symfony-specific setup (symfony/flex) like
the other symfony matrix entries; also verify any job-name templates referencing
matrix.laravel are only used in the laravel job or updated to reference the
correct matrix key so they won't be empty for Symfony entries.
Motivation
Symfony 8.0 unsupported
Changes
Update composer.json
How to test
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.