Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added filepath walk to traverse through files in sub-dirs #4

Conversation

Athe1stB
Copy link

@Athe1stB Athe1stB commented Aug 24, 2024

Closes #3

Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Copy link
Owner

@mainak55512 mainak55512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Athe1stB, ran the changes locally, facing issues to open files from sub-directories, also there are some warnings in getFile() function.
merge_req

@Athe1stB
Copy link
Author

This issue isn't with the getFiles() method. This issue persists from earlier where os isn't able to open the hidden files(files starting with a ..
Will update this as part of this PR.

Also, I do not see any warnings because of logrus. Can you state more about the warning?

@mainak55512
Copy link
Owner

This issue isn't with the getFiles() method. This issue persists from earlier where os isn't able to open the hidden files(files starting with a .. Will update this as part of this PR.

Also, I do not see any warnings because of logrus. Can you state more about the warning?

I guess there is some file path related issue, which is leading to panic. In the earlier version if I go to the exact path and then run the command it is working fine, It seems the program is unable to find the exact file location.

And the logrus.Debug method do not expect any placeholder so I believe the %s is causing the warning.
stto_edited

Signed-off-by: Athe1stB <esper.developer@gmail.com>
@mainak55512
Copy link
Owner

Hi @Athe1stB, two pull requests have been merged recently, could you please check and adjust your changes accordingly so that merge conflicts can be avoided.

Thanks in advance

@mainak55512 mainak55512 added the enhancement New feature or request label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to traverse into sub-directories
2 participants