-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added filepath walk to traverse through files in sub-dirs #4
fix: added filepath walk to traverse through files in sub-dirs #4
Conversation
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Signed-off-by: Athe1stB <esper.developer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Athe1stB, ran the changes locally, facing issues to open files from sub-directories, also there are some warnings in getFile() function.
This issue isn't with the Also, I do not see any warnings because of |
Signed-off-by: Athe1stB <esper.developer@gmail.com>
Hi @Athe1stB, two pull requests have been merged recently, could you please check and adjust your changes accordingly so that merge conflicts can be avoided. Thanks in advance |
Closes #3