Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative base root for Vite #33

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Use relative base root for Vite #33

merged 1 commit into from
Aug 10, 2024

Conversation

pichfl
Copy link
Collaborator

@pichfl pichfl commented Aug 9, 2024

This makes the presentations more portable.

Closes #15

@pichfl
Use relative base root for Vite
f5349af 
This makes the presentations more portable.

Closes #15
@pichfl pichfl added the enhancement New feature or request label Aug 9, 2024
mansona
mansona approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested this locally 😂 :shipit:

@pichfl pichfl merged commit 38db217 into main Aug 10, 2024
3 checks passed
@pichfl pichfl deleted the pichfl/15-relative branch August 10, 2024 20:01
@pichfl
Copy link
Collaborator Author

pichfl commented Aug 10, 2024

Indeed, I did.

@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use relative paths for assets
2 participants
@pichfl @mansona