Add Octane GitHub guide. #1832
Merged
Add Octane GitHub guide. #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| temporary authorization code. The temporary authorization code acts as a | ||
| single use bridge to authorization. | ||
|
|
||
| ### Add `ember-simple-auth` Mixins to Routes |
There was a problem hiding this comment.
Any chance you could add how to use a custom mixin ... I'm trying to override authenticationRoute
jayjayjpg
reviewed
Jul 25, 2019
| As with the original `ember-simple-auth` guide, the approach here mirrors any | ||
| OAuth2 explicit grant flow used also by Facebook, Google, etc. | ||
|
|
||
| You can find a sequence diagram for the flow [here](http://github.com/simplabs/ember-simple-auth/guides/assets/esa-initial-flow.txt.png). |
There was a problem hiding this comment.
It seems the link does not return an image yet - can you check if this works for you?
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
|
@jessica-jordan Thanks for the edits! I've looked over the document and made some more changes incorporating your comments. |
jayjayjpg
reviewed
Aug 1, 2019
jayjayjpg
reviewed
Aug 1, 2019
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
jayjayjpg
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, all. I made great use of the GitHub guide to implement GitHub authentication/authorization on an Ember Octane app I'm working on, but I didn't like that the current guide:
ember-ajaxSo I updated it and offer the update here as a complement, instead of replacement, to the original. Thanks!