Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI config #2229

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Fix CI config #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9712135
fix CI config
marcoow Aug 10, 2020
4a08185
fix capitatilazation of header
marcoow Aug 10, 2020
55ad3d3
set default for allow-failure
marcoow Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
- test:one ember-release
- test:one ember-beta
- test:one ember-canary
allow-failure: [false]
include:
- test-suite: "test:one ember-canary"
allow-failure: true
Expand All @@ -88,7 +89,7 @@ jobs:

- name: tests
run: yarn workspace ${{ matrix.workspace }} ${{ matrix.test-suite }}
continue-on-error: ${{matrix.allow-failure}}
continue-on-error: ${{ matrix.allow-failure }}

extra-tests:
name: Tests (Floating Dependenies)
Expand Down
4 changes: 2 additions & 2 deletions packages/ember-simple-auth/tests/unit/authenticators/oauth2-password-grant-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ describe('OAuth2PasswordGrantAuthenticator', () => {

it('sends an AJAX request to the token endpoint with customized headers', async function() {
server.post('/token', (request) => {
expect(request.requestHeaders['x-custom-context']).to.eql('foobar');
expect(request.requestHeaders['X-Custom-Context']).to.eql('foobar');

return [200, { 'Content-Type': 'application/json' }, '{ "access_token": "secret token!" }'];
});
Expand Down Expand Up @@ -279,7 +279,7 @@ describe('OAuth2PasswordGrantAuthenticator', () => {
await authenticator.authenticate('username', 'password');
expect(false).to.be.true;
} catch (error) {
expect(error.headers.get('x-custom-context')).to.eql('foobar');
expect(error.headers.get('X-Custom-Context')).to.eql('foobar');
}
});
});
Expand Down