Fix empty object check in _renew() cookie session store
#2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Jan 28, 2021
| @@ -287,7 +287,7 @@ export default BaseStore.extend({ | |||
|
|
|||
| _renew() { | |||
| return this.restore().then((data) => { | |||
| if (!isEmpty(data) && data !== {}) { | |||
| if (!isEmpty(data) && !(data.constructor === Object && Object.keys(data).length === 0)) { | |||
There was a problem hiding this comment.
I'm not sure why data !== {} was added at all since isEmpty should handle the case we're trying to prevent against here anyway?
There was a problem hiding this comment.
Also unintuitively, Ember's isEmpty doesn't check for empty objects: https://api.emberjs.com/ember/release/classes/@ember%2Futils/methods?anchor=isEmpty
isEmpty({}); // false
marcoow
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_renewimplementation in the cookie session store includes a check fordata !== {}.While this deceptively looks like it's checking for an empty object,
{} === {}isfalsein JavaScript so the check never resolved. This replaces that check with an alternative that correctly identifies empty objects.