Update dependencies #133
Update dependencies #133
Conversation
package.json
Outdated
| "ember-cli-qunit": "^4.0.0", | ||
| "ember-cli-shims": "^1.1.0", | ||
| "ember-disable-prototype-extensions": "^1.1.0", | ||
| "ember-cli-sri": "^2.1.1", | ||
| "ember-cli-uglify": "^1.2.0", |
There was a problem hiding this comment.
I don't think we need sri and uglify here
There was a problem hiding this comment.
Those are added by ember init - I guess makes sense to add anyway so we don't need to remember to not add them again whenever we update ember-cli?
There was a problem hiding this comment.
to be honest, I'm not a big fan of using ember init for CLI updates anyway... and adding unused dependencies just because CLI has them is not a good reason IMHO, even if they're only dev deps
There was a problem hiding this comment.
What would one use instead of ember init?
There was a problem hiding this comment.
package.json
Outdated
| "ember-cli-sri": "^2.1.1", | ||
| "ember-cli-uglify": "^1.2.0", | ||
| "ember-disable-prototype-extensions": "^1.1.2", | ||
| "ember-export-application-global": "^2.0.0", |
There was a problem hiding this comment.
we don't need this one either
| 'PhantomJS' | ||
| ], | ||
| 'launch_in_dev': [ | ||
| launch_in_dev: [ | ||
| 'PhantomJS', | ||
| 'Chrome' |
There was a problem hiding this comment.
unrelated to this PR, but we should update to headless Chrome here soon
🆙