Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and modernize README file #441

Merged
merged 8 commits into from
Nov 22, 2019
Merged

Simplify and modernize README file #441

merged 8 commits into from
Nov 22, 2019

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Nov 22, 2019

Resolves #440 and updates the README for the Ember Octane world

It's not officially deprecated yet since angle bracket syntax has mostly made this obsolete, but we shouldn't be promoting this as a feature anymore either.
This is no longer relevant with angle bracket syntax and just makes the addon harder to understand.
This helper hasn't been available for quite some time.
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one optional suggested change for clarity. I approved becuase it's really up to you if you want to include it 👍

README.md Outdated Show resolved Hide resolved
@Turbo87 Turbo87 merged commit 51014f8 into mainmatter:master Nov 22, 2019
@Turbo87 Turbo87 deleted the docs branch November 22, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to use this for addon authors
2 participants