Add support for component data-test-* attributes without values #55
Conversation
This adds support for `{{my-component data-test-foo}}`.
Basically, this adds a handlebars transform that converts the previous
example to `{{my-component data-test-foo=true}}`.
| @@ -35,6 +35,14 @@ module.exports = { | |||
| plugin: StripTestSelectorsTransform, | |||
| baseDir: function() { return __dirname; } | |||
| }); | |||
| } else { | |||
| var TransformTestSelectorParamsToHashPairs = require('./transform-test-selector-params-to-hash-pairs'); | |||
There was a problem hiding this comment.
I think? this is where this should be but I'm definitely not sure.
|
@HeroicEric nice work! there is one small caveat though, because you now can no longer pass a |
|
What will actually render though? I'm thinking if it renders <div data-test-foo>…that's fine but if it renders <div data-test-foo="true">…we're adding additional complexity with this. |
|
it should render the first code block, but I'll verify that later. |
|
@marcoow seems to do exactly what we want:
|
|
@HeroicEric there were two issues that caused the tests to fail:
|
|
Wohooo! Thanks @HeroicEric! |
|
released as |
Transforms
to:
Description
This adds support for
{{my-component data-test-foo}}.Basically, this adds a handlebars transform that converts the previous example to
{{my-component data-test-foo=true}}, which already works.I understand if you'd rather not accept this feature but I thought it might be nice since this style selector is supported for regular elements 😄
Use case:
The app I'm currently working on uses a lot of
<div data-test-foo>style test selectors. I'd like to extract some of these elements into components but the current situation with the component support would require either coming up with values for each of thedata-test-*attributes or usingdata-test-foo=truethroughout the app.