fix: strip data-test-* attributes without explicit value from production build #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, we have this already but apparently seems to break for (optional) positional params. |
|
It is a different thing, it is about binding to the element without a value. But PR fixes removing attributes from production build where attributeBindings for data-test-* is not done. |
|
If you want to replicate the issue, simply set |
Turbo87
force-pushed
the
positional-params-data-test-attrs
branch
2 times, most recently
from
6b7a645
to
99980dc
Compare
Turbo87
force-pushed
the
positional-params-data-test-attrs
branch
from
99980dc
to
260d156
Compare
|
released as v0.3.1, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes use case like:
{{my-component "param1" data-test-something}}Real world example:
{{#link-to 'route' data-test-link}}Link{{/link-to}}This would fail on production build by being completely broken link, because link-to actually would receive
'route' undefinedas input. As second argument is meant to be "model" on link-to, then this causes major problems.Sorry for the package.json showing up in diff, rebased went a bit into woods.