Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Switch to treeForAddonTestSupport" #92

Merged
merged 1 commit into from
Apr 7, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Apr 7, 2017

Reverts #89

This unfortunately caused:

Error: Could not find module `ember-test-selectors/utils/bind-data-test-attributes` imported from `(require)`

As we strip out test selectors from the production builds anyways it likely doesn't actually make much sense to add the lib source to the test-support.js file instead of vendor.js since the addon won't actually be able to do anything.

/cc @rwjblue

@Turbo87 Turbo87 force-pushed the revert-89-treeForAddonTestSupport branch from 73f5cab to c018620 Compare April 7, 2017 14:55
@Turbo87 Turbo87 merged commit b5628cc into master Apr 7, 2017
@Turbo87 Turbo87 deleted the revert-89-treeForAddonTestSupport branch April 7, 2017 15:24
@marcoow
Copy link
Member

marcoow commented Apr 8, 2017

Is there any way for us to know that "this is a production build but we still want it so be testable". Also, another question would be of course how people actually test production builds in reality. I guess in most cases they'd use it as a sanity check to make sure that the built bundle actually works so that the tested bundle would actually be the one that gets deployed to production if all tests pass? When using ember-test-selectors you can obviously never test the exact build you're deploying to production (which is certainly not ideal but a necessary shortcoming of the approach we're taking with this addon).

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Apr 10, 2017

Is there any way for us to know that "this is a production build but we still want it so be testable".

nope

When using ember-test-selectors you can obviously never test the exact build you're deploying to production

correct, which is why I don't think we should worry about that case in this addon. it's simply not compatible with this approach.

@Turbo87 Turbo87 added the bug label Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants