Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step size selection broken #804

Closed
dw-0 opened this issue May 15, 2022 · 0 comments · Fixed by #805
Closed

Step size selection broken #804

dw-0 opened this issue May 15, 2022 · 0 comments · Fixed by #805
Labels
⚡ Type: Bug Something isn't working

Comments

@dw-0
Copy link
Member

dw-0 commented May 15, 2022

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

The following line is causing an issue where, no matter which step the user selects, the actual stepSize value is hardcoded.

private stepSize = this.stepsReversed[this.selectedCrossStep]

No matter which step size is selected, they will all send the same value of that step size, that was selected upon rendering the component.

E.g. if the component was rendered with a step size of 10 selected, all buttons will send a movement of 10mm.
Switching to a different step size, for example 25, changing the page and coming back to the dashboard (so causing a reload of that component), all steps will now be 25mm.

What did you expect to happen instead?

Correct step sizes applied upon toggling a different step size button

How to reproduce this bug?

See "what happened".

Additional information:

No response

@dw-0 dw-0 added the ⚡ Type: Bug Something isn't working label May 15, 2022
dw-0 added a commit to dw-0/mainsail that referenced this issue May 15, 2022
…l-crew#804)

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
@dw-0 dw-0 linked a pull request May 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant