Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows adjustable tab size in file editor #1354

Conversation

forgodtosave
Copy link
Contributor

With this PR, you can change the tab size in codemirror via the editor settings.

This PR will fix #1304

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
cz.json 2 0
da.json 6 0
de.json 2 0
en.json 0 0
es.json 144 2
fr.json 6 0
hu.json 143 2
it.json 299 2
ja.json 4 0
ko.json 146 2
nl.json 6 0
pl.json 143 2
ru.json 143 2
sv.json 260 2
tr.json 57 1
uk.json 119 2
zh.json 6 0
zh_TW.json 378 2

@meteyou
Copy link
Member

meteyou commented Apr 25, 2023

hey! thx for your PR. Are you able to read/write every of this languages?

@forgodtosave
Copy link
Contributor Author

Hi, not all of them. But de, ja, ru, hu should be correct and also nl and fr but here I'm not 100% sure.

@meteyou
Copy link
Member

meteyou commented Apr 30, 2023

pls remove all translations, where you are not 100% sure. these should then be translated by native speakers.

@dw-0
Copy link
Member

dw-0 commented Apr 30, 2023

Honestly i would prefer to remove the changes to ALL translations but german and (obviously) english. A lot of the other translations are outdated anyways and require an overall rework of a (at best) native speaker of those languages.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
es.json 146 2
hu.json 143 2
ru.json 143 2

@forgodtosave
Copy link
Contributor Author

I removed all translations except for en and de and languages where I asked a native speaker if it is correct.

@meteyou
Copy link
Member

meteyou commented May 1, 2023

are you able to run prettier to fix the last code issues?

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
es.json 146 2
hu.json 143 2
ru.json 143 2

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
hu.json 143 2
ru.json 143 2

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
hu.json 143 2
ru.json 143 2

src/components/inputs/Codemirror.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsEditorTab.vue Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Language file analysis report:

File Missing Keys Unused Keys
de.json 2 0
en.json 0 0
hu.json 143 2
ko.json 149 2
ru.json 143 2

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

Language file analysis report:

File Missing Keys Unused Keys
da.json 9 0
de.json 2 0
en.json 0 0
hu.json 143 2
ko.json 149 2
ru.json 143 2

@meteyou meteyou merged commit ea274c6 into mainsail-crew:develop May 7, 2023
@meteyou
Copy link
Member

meteyou commented May 7, 2023

Thx for this PR!

@forgodtosave forgodtosave deleted the FR1304_Allow-adjustable-tab-size-in-file-editor branch May 7, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adjustable tab size in file editor
3 participants