Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(es): Update Spanish translation #1548

Merged
merged 4 commits into from
Sep 23, 2023

Conversation

lotusotho
Copy link
Contributor

Description

This PR updates/adds more lines to the Spanish translation

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Language file analysis report:

File Missing Keys Unused Keys
es.json 145 7

@meteyou
Copy link
Member

meteyou commented Sep 6, 2023

do you need help to find the "missing keys"?

@lotusotho
Copy link
Contributor Author

No worries, I'll eventually translate them all, I'm learning about translation keys as I go haha

@lotusotho
Copy link
Contributor Author

lotusotho commented Sep 6, 2023

I'll make a commit for the PR whenever I have the full file

@meteyou
Copy link
Member

meteyou commented Sep 6, 2023

@lotusotho thx! i'll leave this PR open for your commits. Except I publish a release before, then I merge this PR before the release.

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
es.json 8 4

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
es.json 3 4

@lotusotho
Copy link
Contributor Author

lotusotho commented Sep 12, 2023

Tried to fill in as much missing keys as possible. There are 3 left, but I couldn't find them, nevertheless here is the lastest version of es.json

@meteyou
Copy link
Member

meteyou commented Sep 12, 2023

Thx for your update. These are the last missing keys:

  • Panels.KlippyStatePanel.PowerOn
  • Settings.GeneralTab.MainsailSettingsMoonrakerDb
  • Heightmap.CurrentMesh.Range

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
es.json 0 4

@lotusotho
Copy link
Contributor Author

Nice! Thanks for the help!

@meteyou meteyou merged commit 79014ac into mainsail-crew:develop Sep 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants