Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(history): add missing fields in detail dialog #1940

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jul 13, 2024

Description

This PR adds the missing fields in the print history details dialog. I think they dropped in one of the Moonraker sensor PRs for the History view.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick July 13, 2024 20:56
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 13, 2024
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
de.json 0 0
en.json 0 0

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2024
@meteyou meteyou merged commit 7a877b2 into mainsail-crew:develop Jul 14, 2024
13 checks passed
@meteyou meteyou deleted the fix/fix-history-details branch July 14, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants