Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MediaMTX): fix some connection issues #1979

Merged
merged 9 commits into from
Aug 24, 2024
Merged

fix(MediaMTX): fix some connection issues #1979

merged 9 commits into from
Aug 24, 2024

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Aug 21, 2024 •
edited
Loading

Description

This PR fix these WebRTC connection issues:

  • double connections
  • terminate session when backend is not available
  • start/stop when open/close panel on the dashboard
  • start stream in webcam page, when dashboard panel is closed

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou
refactor: refactor then/catch to try/catch
fb21211 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): fix webcam state when panel is closed on dashboard
f4aa3a5 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
mryel00
mryel00 previously approved these changes Aug 23, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2024
@meteyou
fix(MediaMTX): catch setRemoteDescription errors
1778832 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): fix dashboard expand function
6250fcb 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): change error if backend is not readable
5ca8faa 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): add page setting for settings page
adf67d5 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): fix connection issue
f379710 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): fix connection issue
1f8502c 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix(MediaMTX): cancel open restarts, before start connecting
d947f95 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou changed the title fix(MediaMTX): fix double connection to backend fix(MediaMTX): fix some connection issues Aug 24, 2024
@meteyou meteyou marked this pull request as ready for review August 24, 2024 16:03
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 24, 2024
@meteyou meteyou merged commit 85c5774 into mainsail-crew:develop Aug 24, 2024
13 checks passed
@meteyou meteyou deleted the fix/fix-mediamtx-double-connection branch August 24, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mryel00 mryel00 mryel00 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteyou @mryel00