refactor(ControlPanel): use SAVE/RESTORE STATE when moving

[meteyou]

Description

This PR should switch to SAVE_GCODE_STATE/RESTORE_GCODE_STATE to set everytime back to the original movement mode.

Related Tickets & Documents

Comment from @pedrolamas in the extrude panel PR: #1965 (comment)

Mobile & Desktop Screenshots/Recordings

Bildschirmaufnahme.2024-09-01.um.23.56.39.mov

[optional] Are there any post-deployment tasks we need to perform?

none

[zellneralex]

Tested several edge cases:

• very slow moves (1mm/sec) and tried to modify other values like babystepping, speed and extruder factor while the move is ongoing
• multiple hitting of the move arrow while slow and fast (100 mm/sec) moves. System starts in absolute and must also end in that mode.

All tests where PASS so that I would approve the change

[pedrolamas]

I guess the question now is in terms of value provided: I do think this makes sense, but does it solve a problem or provide new value?

The only downside I could see is that it adds a lot of "noise" to the logs... but even that is mitigatable, I think!

[meteyou]

I guess the question now is in terms of value provided: I do think this makes sense, but does it solve a problem or provide new value?

The only downside I could see is that it adds a lot of "noise" to the logs... but even that is mitigatable, I think!

It only brings the "added value" that the previous mode is always set again. Some users, for example, do not have absolute mode in their start macro. We have already had a few support-requests as to "why the printer cannot print after a movement" (out-of-range message).

Where you should say, “Please fix your gcode/macros”... So it's a trade-off between “error protection” vs “noise in the console”.

[meteyou]

@pedrolamas thx for your suggestion! you are complete right. i also opened a PR to rename the gcode_state name in the extruder panel.