Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Review Themes Chapter in Documentation #486

Merged
merged 19 commits into from
Jan 19, 2022
Merged

docs: Review Themes Chapter in Documentation #486

merged 19 commits into from
Jan 19, 2022

Conversation

prcutler
Copy link
Contributor

I reviewed and edited the themes chapter. Please let me know if there is anything you'd like changed.

Thanks!

--P

Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
SIgned-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
… localization

Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
@prcutler
Copy link
Contributor Author

i did not do that right - this PR has all the documentation updates I've been working on. I branched incorrectly.

Just the last commig (fac7972) should be reviewed and see PR #478 for the other documentation updates. Or review just this one and close the other?

I'm sorry, not sure how to fix this once it's done.

@meteyou meteyou changed the title Review Themes Chapter in Documentation docs: Review Themes Chapter in Documentation Dec 31, 2021
prcutler and others added 2 commits January 1, 2022 12:58
@@ -11,7 +11,9 @@ description: >-
# {{ page.title }}
{{ page.description }}

## .theme folder
## Preparing your custom theme
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this section again. I think there are duplicated paragraphs. :D

Copy link
Contributor

@lixxbox lixxbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please recheck the one section with the hidden files again.
The rest is fine in my opinion.

@lixxbox lixxbox added the Is: Docs Anything referencing documentation label Jan 7, 2022
@lixxbox lixxbox self-assigned this Jan 18, 2022
@lixxbox lixxbox merged commit 702981e into mainsail-crew:develop Jan 19, 2022
lixxbox pushed a commit that referenced this pull request Jan 20, 2022
Followup to #486 

Signed-off-by Paul Cutler paul@paulcutler.org
Co-authored-by: lixxbox <lixxbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Is: Docs Anything referencing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants