-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Review Themes Chapter in Documentation #486
Conversation
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
SIgned-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
… localization Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
Signed-off-by Paul Cutler paul@paulcutler.org
i did not do that right - this PR has all the documentation updates I've been working on. I branched incorrectly. Just the last commig (fac7972) should be reviewed and see PR #478 for the other documentation updates. Or review just this one and close the other? I'm sorry, not sure how to fix this once it's done. |
Signed-off-by Paul Cutler paul@paulcutler.org
@@ -11,7 +11,9 @@ description: >- | |||
# {{ page.title }} | |||
{{ page.description }} | |||
|
|||
## .theme folder | |||
## Preparing your custom theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this section again. I think there are duplicated paragraphs. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please recheck the one section with the hidden files again.
The rest is fine in my opinion.
Followup to #486 Signed-off-by Paul Cutler paul@paulcutler.org Co-authored-by: lixxbox <lixxbox@users.noreply.github.com>
I reviewed and edited the themes chapter. Please let me know if there is anything you'd like changed.
Thanks!
--P