-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework heightmap page #667
Merged
meteyou
merged 18 commits into
develop
from
refactor/bed_mesh-move-rename-to-current-mesh-panel
Feb 20, 2022
Merged
feat: rework heightmap page #667
meteyou
merged 18 commits into
develop
from
refactor/bed_mesh-move-rename-to-current-mesh-panel
Feb 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
meteyou
commented
Feb 20, 2022
- move rename button from top panel to current mesh and profiles list
- rework bed_mesh profiles list
- fix round issue of variance
- reorder heightmap settings
- allow spaces in profile names
Signed-off-by: Stefan Dej <meteyou@gmail.com>
# Conflicts: # src/pages/Heightmap.vue
…h panel Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
…e z-max Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
… spaces Signed-off-by: Stefan Dej <meteyou@gmail.com>
… feature Signed-off-by: Stefan Dej <meteyou@gmail.com>
Size Change: +216 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
…bedmesh panel Signed-off-by: Stefan Dej <meteyou@gmail.com>
dw-0
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DNLGTM!
Signed-off-by: Stefan Dej <meteyou@gmail.com>
dw-0
requested changes
Feb 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the german translation! Thank you very much :)
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
dw-0
approved these changes
Feb 20, 2022
meteyou
deleted the
refactor/bed_mesh-move-rename-to-current-mesh-panel
branch
February 20, 2022 21:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.