Rename classes #29
Merged
Rename classes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairas
force-pushed
the
rename_classes
branch
from
ca39598
to
ae69ec0
Compare
mairas
force-pushed
the
rename_classes
branch
from
ae69ec0
to
13a0e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that at its core ReactESP implements an async event loop, the implementation class names could be clearer. This PR renames the classes as follows:
The old names are still provided for compatibility.
Additionally, this PR also removes the singleton functionality. The user is now responsible for maintaining the event loop pointer. I intended to propose this in a separate PR but accidentally squashed the PRs and only noticed it after quite a bit of git history mangling.