Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ppc64le proxy build issue for go-protoc-bin #308

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Swapnali911
Copy link
Contributor

Fixed proxy build for maistra 2.5 for Ppc64le

bazel-out/ppc-opt-exec-2B5CBBC6/bin/external/io_bazel_rules_go/go/tools/builders/go-protoc/go-protoc-bin: bazel-out/ppc-opt-exec-2B5CBBC6/bin/external/io_bazel_rules_go/go/tools/builders/go-protoc/go-protoc-bin: cannot execute binary file
Target //:envoy failed to build
ERROR: /root/.cache/bazel/_bazel_root/8db9a95ef420fca632dcc10027fd7a66/external/envoy_api/envoy/service/discovery/v3/BUILD:7:18 Middleman _middlemen/@envoy_Uapi_S_Senvoy_Sservice_Sdiscovery_Sv3_Cpkg_Ucc_Uproto-cc_library-compile failed: (Exit 126): go-protoc-bin failed: error executing command (from target @com_envoyproxy_protoc_gen_validate//validate:validate_go_proto)

Result:

Build succeeded. Binary generated:
+ bazel-bin/envoy --version

bazel-bin/envoy  version: ae3bbc4313b45af63777a2588388796d74221cfd/1.26.8-dev/Modified/RELEASE/OpenSSL

Copy link

openshift-ci bot commented Feb 22, 2024

Hi @Swapnali911. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Swapnali911
Copy link
Contributor Author

Hi @jwendell Could you please review and merge this request. Thanks.

@twghu
Copy link
Contributor

twghu commented Feb 22, 2024

Testing patch locally seems ok, unless @jwendell sees a problem + ack

@twghu twghu requested review from jwendell and twghu February 22, 2024 08:05
@jwendell
Copy link
Member

/ok-to-test

@dcillera
Copy link
Contributor

/override ci/prow/maistra-envoy-unit-2-5

Copy link

openshift-ci bot commented Feb 26, 2024

@dcillera: Overrode contexts on behalf of dcillera: ci/prow/maistra-envoy-unit-2-5

In response to this:

/override ci/prow/maistra-envoy-unit-2-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 66caee7 into maistra:maistra-2.5 Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants