MAISTRA-1071 Add manifest namespace validation #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcernich
reviewed
Jul 14, 2020
| @@ -80,6 +82,22 @@ func (v *versionStrategyV1_1) Validate(ctx context.Context, cl client.Client, sm | |||
| } | |||
| } | |||
| } | |||
| smmr := &v1.ServiceMeshMemberRoll{} | |||
There was a problem hiding this comment.
Do we need this same check for the 1.0 and 1.2/2.0 validators?
There was a problem hiding this comment.
Yes, but I wanted to wait for your adjustment (re)introducing the loop over gateways
rcernich
approved these changes
Jul 14, 2020
|
I rebased the branch to be compatible with the v2 smcp changes |
luksa
approved these changes
Jul 20, 2020
|
@dgn: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dgn
added a commit
to dgn/istio-operator
that referenced
this pull request
Aug 3, 2020
This reverts commit e60ad52.
dgn
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #462